From a4ec8114966394c663462ca103bbea2bcf7465d8 Mon Sep 17 00:00:00 2001 From: Liu Rui Date: Thu, 11 Jan 2024 14:17:50 +0800 Subject: [PATCH] fix-Process-Create-options-Unused ``` static ProcessBuilder create(Vertx vertx, String command, ProcessOptions options) { return create(vertx, command, Collections.emptyList(), new ProcessOptions()); } ``` I've identified a bug in the create method of the ProcessBuilder class. The method signature suggests that it should use the ProcessOptions options parameter provided by the caller. However, in the current implementation, the method disregards this parameter and instead creates a new ProcessOptions object. This behavior could lead to unexpected issues, as any custom configurations passed through the options parameter are not being utilized. --- src/main/java/com/julienviet/childprocess/Process.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/julienviet/childprocess/Process.java b/src/main/java/com/julienviet/childprocess/Process.java index 568f9a7..fb4248e 100644 --- a/src/main/java/com/julienviet/childprocess/Process.java +++ b/src/main/java/com/julienviet/childprocess/Process.java @@ -79,7 +79,7 @@ static ProcessBuilder create(Vertx vertx, String command, List args) { * @return the created child process */ static ProcessBuilder create(Vertx vertx, String command, ProcessOptions options) { - return create(vertx, command, Collections.emptyList(), new ProcessOptions()); + return create(vertx, command, Collections.emptyList(), options); } /**