Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional backend support (file, proxy-to) #1

Open
wants to merge 1 commit into
base: initial-work
from

Conversation

Projects
None yet
2 participants
@EricWittmann
Copy link

commented Sep 1, 2016

  • added file and proxy-to providers
  • added support for a config file
  • made a couple small code-cleanup changes (unused vars)
added file and proxy-to providers, added support for a config file, m…
…ade a couple small code-cleanup changes (unused vars)
@vietj

This comment has been minimized.

Copy link
Owner

commented Sep 23, 2016

Overall it seems good addition, however it is necessary to have tests, specially the proxy-to support is not tested.

@EricWittmann

This comment has been minimized.

Copy link
Author

commented Sep 26, 2016

OK that's fair - I'll put some tests together.

I also haven't yet had a chance to look at failure paths. I know that's one of the things you're concerned about with respect to the vert.x client and server apis. Not sure when I'll have a chance to do some testing on that front, but it's still on my to-do list.

@vietj vietj force-pushed the vietj:initial-work branch from a5f3f80 to 27c09fa Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.