Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS vulnerability in nav_path template data #137

Closed
cmpilato opened this issue Jan 24, 2017 · 1 comment
Closed

XSS vulnerability in nav_path template data #137

cmpilato opened this issue Jan 24, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@cmpilato
Copy link
Contributor

ViewVC does not properly escape the names of versioned directories and files before making them available for use via its nav_path HTML template variables. These variables are used in ViewVC's default templates, and would likely be used in folks' customized templates, too. A user with commit privileges to the repository could introduce a versioned directory or file with a name that contains an executable script (e.g., <img src="#" onerror="alert(1)">), and the script would be evaluated upon a user's navigation (via web browser) to ViewVC's view of that directory or file.

@cmpilato cmpilato added the bug label Jan 24, 2017
@cmpilato cmpilato added this to the 1.1.26 milestone Jan 24, 2017
@cmpilato cmpilato self-assigned this Jan 24, 2017
@cmpilato
Copy link
Contributor Author

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant