add react-streaming #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💯 |
|
Released as (I ain't forgetting about your Vike PR and your DMs, I'll get back to you about these next week. But let me know if you're blocked and I'll have a look at it this weekend.) |
lourot
reviewed
Nov 17, 2023
| @@ -12,20 +12,16 @@ import React from 'react' | |||
| checkVikeVersion() | |||
|
|
|||
| const onRenderHtml: OnRenderHtmlAsync = async (pageContext): ReturnType<OnRenderHtmlAsync> => { | |||
| let pageHtml = '' | |||
| if (!!pageContext.Page) { | |||
There was a problem hiding this comment.
when pageContext.Page is undefined here this means that ssr: false is being used. Should we still be making use of renderToStream() in this case?
Comment on lines
+8
to
+10
| if (!pageContext.Page) { | ||
| return <></> | ||
| } |
There was a problem hiding this comment.
I'm not sure this is correct to have moved this early return here? As we may have two cases to differentiate:
Pagemay be undefined but we may still want to render the Wrapper and the Layout, orPageis undefined because we are running on server and SSR is disabled, in which case not rendering anything is correct. But we don't know this in this function and we shouldn't. This is why this was handled inonRenderHtmlin the previous version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.