Corrected incorrect method in latest version. #3

Merged
merged 1 commit into from Aug 9, 2012

Conversation

Projects
None yet
2 participants

ghost commented Aug 9, 2012

Update:

albumiterator.c - correction to method-call within PHP_METHOD(SpotifyAlbumIterator, offsetGet).

@vilhelmk

This comment has been minimized.

Show comment Hide comment
@vilhelmk

vilhelmk Aug 9, 2012

Owner

Thanks for the patch.

It's hard for me to see exactly what's changed due to the broken diff[1]. Could you either make a proper patch that visualizes the change(s), or explain more what you have changed?

Thanks again.

1: https://github.com/vilhelmk/libspotify-php/pull/3/files

Owner

vilhelmk commented Aug 9, 2012

Thanks for the patch.

It's hard for me to see exactly what's changed due to the broken diff[1]. Could you either make a proper patch that visualizes the change(s), or explain more what you have changed?

Thanks again.

1: https://github.com/vilhelmk/libspotify-php/pull/3/files

- }
-
- p = (spotifyalbumiterator_object*)zend_object_store_get_object(getThis() TSRMLS_CC);
- album = sp_artistbrowse_album(p->artistbrowse, L_ZVAL_P(index));

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Aug 9, 2012

Renamed L_ZVAL_P to Z_LVAL_P as per method override above. Make was throwing errors without this change - assuming this was a typo.

@ghost

ghost Aug 9, 2012

Renamed L_ZVAL_P to Z_LVAL_P as per method override above. Make was throwing errors without this change - assuming this was a typo.

vilhelmk added a commit that referenced this pull request Aug 9, 2012

Merge pull request #3 from ptylr/master
Corrected incorrect method in latest version (Z_LVAL_P typo)

@vilhelmk vilhelmk merged commit 7380ba6 into vilhelmk:master Aug 9, 2012

@vilhelmk

This comment has been minimized.

Show comment Hide comment
@vilhelmk

vilhelmk Aug 9, 2012

Owner

Definitively a typo - thanks.

Owner

vilhelmk commented Aug 9, 2012

Definitively a typo - thanks.

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Aug 9, 2012

Hi,

I have commented the line within the change - unfortunately was using the
GitHub for Windows app, which made the patch in this way - apologies.

Essentially, changed line 149 of albumiterator.c so that L_ZVAL_P is
correctly typed as Z_LVAL_P instead (L_ZVAL_P undefined).

Hope this ok,

Paul

On 9 August 2012 12:23, Vilhelm K. Vardøy notifications@github.com wrote:

Thanks for the patch.

It's hard for me to see exactly what's changed due to the broken diff[1].
Could you either make a proper patch that visualizes the change(s), or
explain more what you have changed?

Thanks again.

1: https://github.com/vilhelmk/libspotify-php/pull/3/files


Reply to this email directly or view it on GitHubhttps://github.com/vilhelmk/libspotify-php/pull/3#issuecomment-7611551.

ghost commented Aug 9, 2012

Hi,

I have commented the line within the change - unfortunately was using the
GitHub for Windows app, which made the patch in this way - apologies.

Essentially, changed line 149 of albumiterator.c so that L_ZVAL_P is
correctly typed as Z_LVAL_P instead (L_ZVAL_P undefined).

Hope this ok,

Paul

On 9 August 2012 12:23, Vilhelm K. Vardøy notifications@github.com wrote:

Thanks for the patch.

It's hard for me to see exactly what's changed due to the broken diff[1].
Could you either make a proper patch that visualizes the change(s), or
explain more what you have changed?

Thanks again.

1: https://github.com/vilhelmk/libspotify-php/pull/3/files


Reply to this email directly or view it on GitHubhttps://github.com/vilhelmk/libspotify-php/pull/3#issuecomment-7611551.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment