Pull Request Guidelines

viljamis edited this page Nov 13, 2012 · 2 revisions
Clone this wiki locally

Please follow these conventions below if you want to do a pull request.


  • Each pull request for a single feature or bug fix
  • If you are planning on doing something big, please discuss first with @viljamis about it
  • Does it fit into the current design?

Code formatting

  • Don’t use tabs to indent, instead use Soft Tabs (spaces) with tab size of 2.
  • Don’t leave trailing whitespaces.
  • Use JSLint with these settings to check and format your JavaScript: /*jslint eqeq: false, plusplus: true, sloppy: true, vars: true, browser: true, devel: true, indent: 2 */
  • When there is minified JavaScript, please use Google’s Closure Compiler to minify the code.