Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node types more strict #23

Merged
merged 5 commits into from Dec 3, 2016
Merged

Make node types more strict #23

merged 5 commits into from Dec 3, 2016

Conversation

haya14busa
Copy link
Member

No description provided.

@haya14busa haya14busa changed the title Make node types more strict & and json arg Make node types more strict and json arg Dec 3, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master.

@haya14busa haya14busa changed the title Make node types more strict and json arg Make node types more strict Dec 3, 2016
@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node {
return newAstNode(self.parse(reader), filename)
}

func (self *ExprParser) Parse() ast.Node {
return newAstNode(self.parse(), "")
func (self *ExprParser) Parse() ast.Expr {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"

@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node {
return newAstNode(self.parse(reader), filename)
}

func (self *ExprParser) Parse() ast.Node {
return newAstNode(self.parse(), "")
func (self *ExprParser) Parse() ast.Expr {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported method ExprParser.Parse should have comment or be unexported

func (*BasicLit) exprNode() {}
func (*List) exprNode() {}
func (*Dict) exprNode() {}
func (*KeyValue) exprNode() {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
func exprNode is unused (U1000)

}

// ExCommand is the interface for Ex-command.
type ExCommand interface {
Node
Cmd() Cmd
stmtNode()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
func stmtNode is unused (U1000)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 83.345% when pulling feef606 on sum-type into 84056cc on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 83.345% when pulling feef606 on sum-type into 84056cc on master.

@coveralls
Copy link

coveralls commented Dec 3, 2016

Coverage Status

Coverage decreased (-0.8%) to 83.363% when pulling 253f161 on sum-type into 84056cc on master.

@haya14busa haya14busa merged commit f57a807 into master Dec 3, 2016
@haya14busa haya14busa deleted the sum-type branch December 3, 2016 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants