New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make node types more strict #23
Conversation
Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master. |
1 similar comment
Coverage decreased (-0.9%) to 83.345% when pulling 3d907a5a32be77b1d2d16154fbbcec9b97d48e4f on sum-type into 47c0128 on master. |
@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node { | |||
return newAstNode(self.parse(reader), filename) | |||
} | |||
|
|||
func (self *ExprParser) Parse() ast.Node { | |||
return newAstNode(self.parse(), "") | |||
func (self *ExprParser) Parse() ast.Expr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog
receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
@@ -11,8 +11,8 @@ func (self *VimLParser) Parse(reader *StringReader, filename string) ast.Node { | |||
return newAstNode(self.parse(reader), filename) | |||
} | |||
|
|||
func (self *ExprParser) Parse() ast.Node { | |||
return newAstNode(self.parse(), "") | |||
func (self *ExprParser) Parse() ast.Expr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog
exported method ExprParser.Parse should have comment or be unexported
func (*BasicLit) exprNode() {} | ||
func (*List) exprNode() {} | ||
func (*Dict) exprNode() {} | ||
func (*KeyValue) exprNode() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog
func exprNode is unused (U1000)
} | ||
|
||
// ExCommand is the interface for Ex-command. | ||
type ExCommand interface { | ||
Node | ||
Cmd() Cmd | ||
stmtNode() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog
func stmtNode is unused (U1000)
No description provided.