Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] reviewdog #128

Merged
merged 1 commit into from May 17, 2020
Merged

[add] reviewdog #128

merged 1 commit into from May 17, 2020

Conversation

get-me-power
Copy link
Member

@get-me-power get-me-power commented May 16, 2020 •
edited

reviewdogを追加するためのパッチを書きました。

issue number

#117

@get-me-power
[add] reviewdog
217800c 
[add] pr_check

[delete] docker checkout

fix error

delete error config

delete flag
@get-me-power
Copy link
Member Author

エラーが出ないように修正したので、一旦squashしてpushしました。
reporterなどの設定はあまりいじってないので、要望があれば都度書き換えたいと思います。

koron
koron approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@koron koron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです。

@koron koron merged commit 1a020d7 into master May 17, 2020
@koron koron deleted the add_reviewdog branch May 17, 2020 01:05
@koron koron mentioned this pull request May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koron koron koron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@get-me-power @koron