Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pi_{tar,zip}.{txt,jax} #1186

Merged
merged 3 commits into from Nov 2, 2022

Conversation

tsuyoshicho
Copy link
Contributor

更新しました。

Copy link
Member

@h-east h-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘箇所以外はLGTMです。

doc/pi_tar.jax Outdated Show resolved Hide resolved
Default
Variable Value Explanation
Default
Variable Value Explanation
*g:tar_browseoptions* "Ptf" used to get a list of contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この行と L101はtypoスレに報告済みです。
vim-jp/issues#1387 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

見てみましたが、この変更を先行してjaxには(とりあえずは)入れないことにします。

あと、g:tar_browseoptions のほうは Default value のセンタリング的にはかえって崩れていませんか?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あれ?変ですか?

こちらでは、現状が以下で、
image

修正後が以下です。
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再度確認しました。
すみません、insertのときにconceal解除してるのですが、そこでのズレを誤認していました.... 🙇
上記のコメントの修正で正しかったです。

Co-authored-by: h_east <h.east.727@gmail.com>
@k-takata k-takata merged commit d7a71e6 into vim-jp:master Nov 2, 2022
@k-takata
Copy link
Member

k-takata commented Nov 2, 2022

thx

@tsuyoshicho tsuyoshicho deleted the update/20221030/pix branch November 2, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants