New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pi_{tar,zip}.{txt,jax} #1186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
指摘箇所以外はLGTMです。
Default | ||
Variable Value Explanation | ||
Default | ||
Variable Value Explanation | ||
*g:tar_browseoptions* "Ptf" used to get a list of contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この行と L101はtypoスレに報告済みです。
vim-jp/issues#1387 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。
見てみましたが、この変更を先行してjaxには(とりあえずは)入れないことにします。
あと、g:tar_browseoptions のほうは Default value のセンタリング的にはかえって崩れていませんか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
再度確認しました。
すみません、insertのときにconceal解除してるのですが、そこでのズレを誤認していました.... 🙇
上記のコメントの修正で正しかったです。
Co-authored-by: h_east <h.east.727@gmail.com>
thx |
更新しました。