Support for POD formatting (e.g. highlight bold as bold) and spell-check enhancements #49

Merged
merged 2 commits into from May 10, 2013

Conversation

Projects
None yet
3 participants
@njohnston
Contributor

njohnston commented Feb 27, 2011

Full details in the commit (6b4ebd06de5d90cef43cd40aff28ed2a5d0886de), but for ease of reference:

  • Adds support for highlighting POD inline text, for example bold as bold and so on.
  • Adds support for spellchecking POD headings (=head1 etc.)
  • Adds support for spellchecking bold and italic inline text.

These changes are generally very useful for identifying typos and incorrect formatting during peer reviews, also simply make editing easier.

Please let me know if you have any questions or comments.

@petdance

This comment has been minimized.

Show comment Hide comment
@petdance

petdance Oct 17, 2011

Contributor

Wouldn't you want to apply these things to syntax/pod.vim instead?

Contributor

petdance commented Oct 17, 2011

Wouldn't you want to apply these things to syntax/pod.vim instead?

@njohnston

This comment has been minimized.

Show comment Hide comment
@njohnston

njohnston Oct 18, 2011

Contributor

The changes are in syntax/pod.vim. Is that what you meant?

Contributor

njohnston commented Oct 18, 2011

The changes are in syntax/pod.vim. Is that what you meant?

@petdance

This comment has been minimized.

Show comment Hide comment
@petdance

petdance Oct 18, 2011

Contributor

My mistake! When I looked at it I thought I was looking at syntax/perl.vim, not syntax/pod.vim. Apologies!

Contributor

petdance commented Oct 18, 2011

My mistake! When I looked at it I thought I was looking at syntax/perl.vim, not syntax/pod.vim. Apologies!

njohnston added some commits Feb 27, 2011

Support for formatting and header spell-check
Added support for formatting - in other words, bold text will be
highlighted in bold, italic text in italic and so on.

Enhanced spell-checking so that headings can be spell-checked. It doesn't
make much sense to me to spell-check paragraphs, but not headings. Text
within B<> and I<> can now also be spell-checked too. Again, it seems
strange not to spell-check text simply because it is bold or italic.

These features are controlled by separate variables: perl_pod_formatting
and perl_pod_spellcheck_headings which would normally be set from your
vimrc file. The features are disabled by default to maintain compatibility.
POD formatting escapes syntax highlighting improvements.
- Closing > characters are now highlighted correctly.
- Formatting escapes like B<>, I<> can now be used in POD commands like
  =head, =item and so on.
@njohnston

This comment has been minimized.

Show comment Hide comment
@njohnston

njohnston Jan 8, 2012

Contributor

Sorry for the delay.

  • B<> and I<> now correctly work inside POD commands like =head, =item, ...
  • B<> and I<> now highlight the closing > as well

I haven't changed F<> or C<> as they don't really imply any specific type of formatting or appearance.

Note GitHub shows my commit from today as if it happened last year--that's because I rebased as I forgot to merge in upstream changes before pushing.

Contributor

njohnston commented Jan 8, 2012

Sorry for the delay.

  • B<> and I<> now correctly work inside POD commands like =head, =item, ...
  • B<> and I<> now highlight the closing > as well

I haven't changed F<> or C<> as they don't really imply any specific type of formatting or appearance.

Note GitHub shows my commit from today as if it happened last year--that's because I rebased as I forgot to merge in upstream changes before pushing.

@njohnston

This comment has been minimized.

Show comment Hide comment
@njohnston

njohnston May 6, 2012

Contributor

Hi. I've updated this pull request like you asked, I'm not sure if you've noticed. If any have any outstanding comments or problems please let me know and I'll try to address them, but I would like to get this into the "standard" Perl syntax highlighting. Thanks.

Contributor

njohnston commented May 6, 2012

Hi. I've updated this pull request like you asked, I'm not sure if you've noticed. If any have any outstanding comments or problems please let me know and I'll try to address them, but I would like to get this into the "standard" Perl syntax highlighting. Thanks.

@hoelzro

This comment has been minimized.

Show comment Hide comment
@hoelzro

hoelzro Dec 18, 2012

Owner

I just tried this out, and I think these are great additions. I'm going to merge it if nobody objects!

Owner

hoelzro commented Dec 18, 2012

I just tried this out, and I think these are great additions. I'm going to merge it if nobody objects!

hoelzro added a commit that referenced this pull request May 10, 2013

Merge pull request #49 from njohnston/master
Support for POD formatting (e.g. highlight bold as bold) and spell-check enhancements

@hoelzro hoelzro merged commit 2cba82e into vim-perl:master May 10, 2013

@hoelzro

This comment has been minimized.

Show comment Hide comment
@hoelzro

hoelzro May 10, 2013

Owner

I've seen no objections, so I'm merging this.

Owner

hoelzro commented May 10, 2013

I've seen no objections, so I'm merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment