New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt GoDoc and rename it to Ri #380

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mluts

mluts commented Oct 20, 2018

Hi, i love ruby and was envious about vim-go's GoDoc, so i decided to adopt their code into vim-ruby.

It's a convenient way to discover rdoc while staying in vim.

Would be grateful if this will be merged into master, feel free to modify.

@dkearns dkearns added the ftplugin label Oct 20, 2018

@tpope

This comment has been minimized.

Member

tpope commented Oct 20, 2018

I think if you want something like this, the way to do it is a generic plugin that looks at 'keywordprg'. I don't think copying and pasting the same code everywhere is the way to go, and even if I accepted it as the best pragmatic course of action, I wouldn't really think it belonged in the standard Ruby ftplugin. It's plenty bloated already.

@tpope tpope closed this Oct 20, 2018

@mluts

This comment has been minimized.

mluts commented Oct 22, 2018

@tpope What i'm struggling with, is that i can't scroll up/down the output of ri in neovim (sorry, i prefer it), the shortest way to achieve that would be set keywordprg=:term\ ri. Already added it to my own vimrc, but other users will suffer from this in default vim-ruby setup and that is little sad.

@mluts mluts deleted the mluts:add-ri-convenience branch Oct 22, 2018

@mluts

This comment has been minimized.

mluts commented Oct 22, 2018

@tpope What i'm struggling with, is that i can't scroll up/down the output of ri in neovim (sorry, i prefer it), the shortest way to achieve that would be set keywordprg=:term\ ri. Already added it to my own vimrc, but other users will suffer from this in default vim-ruby setup and that is little sad.

@tpope

This comment has been minimized.

Member

tpope commented Oct 29, 2018

A generic plugin that calls :term plus 'keywordprg' on the word under the cursor would be pretty short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment