New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: Work with php-5.3 and php-5.4 #320

Merged
merged 1 commit into from Sep 23, 2012

Conversation

Projects
None yet
3 participants
@rbrown
Copy link
Contributor

rbrown commented Aug 14, 2012

The current makeprg doesn't work with php-5.3. display_errors=0 has
disabled error outputting and error_log='' disables the error log. With
php-5.4 error_log='' is causing errors to be logged to stderr.

This patch disables the error_log and enables display_errors.
Theoretically errors are displayed on stdout, however php in mountain
lion seems to insist on outputting to stderr.

As we're now displaying errors rather than logging them to error format
has changed to no longer include 'PHP ' and I've removed duplicates.

This has been tested with PHP 5.3.13 with Suhosin-Patch (cli) (built: Jun 20
2012 17:05:20) (mountain lion) and PHP 5.4.4 (cli) (built: Jul 2 2012
16:33:50) Fedora 17

PHP: Work with php-5.3 and php-5.4
The current makeprg doesn't work with php-5.3. display_errors=0 has
disabled error outputting and error_log='' disables the error log. With
php-5.4 error_log='' is causing errors to be logged to stderr.

This patch disables the error_log and enables display_errors.
Theoretically errors are displayed on stdout, however php in mountain
lion seems to insist on outputting to stderr.

As we're now displaying errors rather than logging them to error format
has changed to no longer include 'PHP ' and I've removed duplicates.

This has been tested with PHP 5.3.13 with Suhosin-Patch (cli) (built: Jun 20
2012 17:05:20)  (mountain lion) and PHP 5.4.4 (cli) (built: Jul  2 2012
16:33:50) Fedora 17
@kusnier

This comment has been minimized.

Copy link
Contributor

kusnier commented Sep 20, 2012

👍

scrooloose added a commit that referenced this pull request Sep 23, 2012

Merge pull request #320 from rbrown/fix_php_53_and_54
PHP: Work with php-5.3 and php-5.4

@scrooloose scrooloose merged commit c98c641 into vim-syntastic:master Sep 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment