patch 8.1.2412: crash when evaluating expression with error

Problem: Crash when evaluating expression with error. (Dhiraj Mishra) Solution: Check parsing failed. (closes #5329)
vim · Dec 8, 2019 · 0ff822d2ebf0d130516631734b00179ba8dd8251 · 0ff822d
1 parent 1b03a19
commit 0ff822d2ebf0d130516631734b00179ba8dd8251
Unified Split

Showing with 8 additions and 1 deletion.

+1 −1 src/eval.c

+5 −0 src/testdir/test_lambda.vim

+2 −0 src/version.c
diff --git a/src/eval.c b/src/eval.c
@@ -2902,7 +2902,7 @@ eval_lambda(
     rettv->v_type = VAR_UNKNOWN;
 
     ret = get_lambda_tv(arg, rettv, evaluate);
-    if (ret == NOTDONE)
+    if (ret != OK)
 	return FAIL;
     else if (**arg != '(')
     {

diff --git a/src/testdir/test_lambda.vim b/src/testdir/test_lambda.vim
@@ -302,3 +302,8 @@ func Test_lambda_with_index()
   let Extract = {-> function(List, ['foobar'])()[0]}
   call assert_equal('foobar', Extract())
 endfunc
+
+func Test_lambda_error()
+  " This was causing a crash
+  call assert_fails('ec{@{->{d->()()', 'E15')
+endfunc
diff --git a/src/version.c b/src/version.c
@@ -742,6 +742,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2412,
 /**/
     2411,
 /**/