Permalink
Browse files

patch 8.0.0899: function name mch_stop_job() is confusing

Problem:    Function name mch_stop_job() is confusing.
Solution:   Rename to mch_signal_job().
  • Loading branch information...
brammool committed Aug 11, 2017
1 parent e41e3b4 commit 2d33e90f81334eee34275a259444434abf56250f
Showing with 10 additions and 8 deletions.
  1. +2 −2 src/channel.c
  2. +1 −1 src/os_unix.c
  3. +1 −1 src/os_win32.c
  4. +1 −1 src/proto/os_unix.pro
  5. +1 −1 src/proto/os_win32.pro
  6. +2 −2 src/terminal.c
  7. +2 −0 src/version.c
View
@@ -4844,7 +4844,7 @@ job_stop_on_exit(void)
for (job = first_job; job != NULL; job = job->jv_next)
if (job->jv_status == JOB_STARTED && job->jv_stoponexit != NULL)
mch_stop_job(job, job->jv_stoponexit);
mch_signal_job(job, job->jv_stoponexit);
}
/*
@@ -5191,7 +5191,7 @@ job_stop(job_T *job, typval_T *argvars, char *type)
return 0;
}
ch_log(job->jv_channel, "Stopping job with '%s'", (char *)arg);
if (mch_stop_job(job, arg) == FAIL)
if (mch_signal_job(job, arg) == FAIL)
return 0;
/* Assume that only "kill" will kill the job. */
View
@@ -5557,7 +5557,7 @@ mch_detect_ended_job(job_T *job_list)
* Return FAIL if "how" is not a valid name.
*/
int
mch_stop_job(job_T *job, char_u *how)
mch_signal_job(job_T *job, char_u *how)
{
int sig = -1;
pid_t job_pid;
View
@@ -5248,7 +5248,7 @@ terminate_all(HANDLE process, int code)
* Return FAIL if it didn't work.
*/
int
mch_stop_job(job_T *job, char_u *how)
mch_signal_job(job_T *job, char_u *how)
{
int ret;
View
@@ -63,7 +63,7 @@ int mch_call_shell(char_u *cmd, int options);
void mch_job_start(char **argv, job_T *job, jobopt_T *options);
char *mch_job_status(job_T *job);
job_T *mch_detect_ended_job(job_T *job_list);
int mch_stop_job(job_T *job, char_u *how);
int mch_signal_job(job_T *job, char_u *how);
void mch_clear_job(job_T *job);
void mch_breakcheck(int force);
int mch_expandpath(garray_T *gap, char_u *path, int flags);
View
@@ -45,7 +45,7 @@ int mch_call_shell(char_u *cmd, int options);
void mch_job_start(char *cmd, job_T *job, jobopt_T *options);
char *mch_job_status(job_T *job);
job_T *mch_detect_ended_job(job_T *job_list);
int mch_stop_job(job_T *job, char_u *how);
int mch_signal_job(job_T *job, char_u *how);
void mch_clear_job(job_T *job);
void mch_set_normal_colors(void);
void mch_write(char_u *s, int len);
View
@@ -1143,7 +1143,7 @@ terminal_loop(void)
/* We don't know if the job can handle CTRL-C itself or not, this
* may kill the shell instead of killing the command running in the
* shell. */
mch_stop_job(curbuf->b_term->tl_job, (char_u *)"quit");
mch_signal_job(curbuf->b_term->tl_job, (char_u *)"quit");
#endif
if (c == (termkey == 0 ? Ctrl_W : termkey) || c == Ctrl_BSL)
@@ -2735,7 +2735,7 @@ term_report_winsize(term_T *term, int rows, int cols)
break;
}
if (part < PART_COUNT && mch_report_winsize(fd, rows, cols) == OK)
mch_stop_job(term->tl_job, (char_u *)"winch");
mch_signal_job(term->tl_job, (char_u *)"winch");
}
}
View
@@ -769,6 +769,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
899,
/**/
898,
/**/

0 comments on commit 2d33e90

Please sign in to comment.