Permalink
Browse files

patch 8.0.0847: :argadd without argument can't handle space in file name

Problem:    :argadd without argument can't handle space in file name. (Harm te
            Hennepe)
Solution:   Escape the space. (Yasuhiro Matsumoto, closes #1917)
  • Loading branch information...
brammool committed Aug 3, 2017
1 parent 7c9aec4 commit 398ee7326b78b892a5c8380dfe3f2521a64b4fa7
Showing with 21 additions and 8 deletions.
  1. +10 −4 src/ex_cmds2.c
  2. +0 −1 src/proto/ex_cmds2.pro
  3. +9 −3 src/testdir/test_arglist.vim
  4. +2 −0 src/version.c
View
@@ -2320,8 +2320,8 @@ do_one_arg(char_u *str)
* Separate the arguments in "str" and return a list of pointers in the
* growarray "gap".
*/
int
get_arglist(garray_T *gap, char_u *str)
static int
get_arglist(garray_T *gap, char_u *str, int escaped)
{
ga_init2(gap, (int)sizeof(char_u *), 20);
while (*str != NUL)
@@ -2333,6 +2333,10 @@ get_arglist(garray_T *gap, char_u *str)
}
((char_u **)gap->ga_data)[gap->ga_len++] = str;
/* If str is escaped, don't handle backslashes or spaces */
if (!escaped)
return OK;
/* Isolate one argument, change it in-place, put a NUL after it. */
str = do_one_arg(str);
}
@@ -2355,7 +2359,7 @@ get_arglist_exp(
garray_T ga;
int i;
if (get_arglist(&ga, str) == FAIL)
if (get_arglist(&ga, str, TRUE) == FAIL)
return FAIL;
if (wig == TRUE)
i = expand_wildcards(ga.ga_len, (char_u **)ga.ga_data,
@@ -2401,6 +2405,7 @@ do_arglist(
char_u *p;
int match;
#endif
int arg_escaped = TRUE;
/*
* Set default argument for ":argadd" command.
@@ -2410,12 +2415,13 @@ do_arglist(
if (curbuf->b_ffname == NULL)
return FAIL;
str = curbuf->b_fname;
arg_escaped = FALSE;
}
/*
* Collect all file name arguments in "new_ga".
*/
if (get_arglist(&new_ga, str) == FAIL)
if (get_arglist(&new_ga, str, arg_escaped) == FAIL)
return FAIL;
#ifdef FEAT_LISTCMDS
View
@@ -52,7 +52,6 @@ int can_abandon(buf_T *buf, int forceit);
int check_changed_any(int hidden, int unload);
int check_fname(void);
int buf_write_all(buf_T *buf, int forceit);
int get_arglist(garray_T *gap, char_u *str);
int get_arglist_exp(char_u *str, int *fcountp, char_u ***fnamesp, int wig);
void set_arglist(char_u *str);
void check_arg_idx(win_T *win);
@@ -65,13 +65,19 @@ func Test_argadd()
%argd
edit d
arga
call assert_equal(len(argv()), 1)
call assert_equal(get(argv(), 0, ''), 'd')
call assert_equal(1, len(argv()))
call assert_equal('d', get(argv(), 0, ''))
%argd
edit some\ file
arga
call assert_equal(1, len(argv()))
call assert_equal('some file', get(argv(), 0, ''))
%argd
new
arga
call assert_equal(len(argv()), 0)
call assert_equal(0, len(argv()))
endfunc
func Init_abc()
View
@@ -769,6 +769,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
847,
/**/
846,
/**/

0 comments on commit 398ee73

Please sign in to comment.