Skip to content

Commit

Permalink
patch 9.0.0591: message window popup shows on only one tab page
Browse files Browse the repository at this point in the history
Problem:    Message window popup shows on only one tab page. (Naruhiko
            Nishino)
Solution:   Show the message window popup on all tab pages. (closes #11231)
  • Loading branch information
brammool committed Sep 26, 2022
1 parent ee09fcc commit 4569020
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/popupwin.c
Expand Up @@ -2053,6 +2053,8 @@ popup_create(typval_T *argvars, typval_T *rettv, create_type_T type)
}
}
}
else if (popup_is_notification(type))
tabnr = -1; // show on all tabs

// Create the window and buffer.
wp = win_alloc_popup_win();
Expand Down
8 changes: 8 additions & 0 deletions src/testdir/dumps/Test_echowindow_8.dump
@@ -0,0 +1,8 @@
| +8#0000001#e0e0e08|+| |[|N|o| |N|a|m|e|]| | +2#0000000#ffffff0|[|N|o| |N|a|m|e|]| | +1&&@49|X+8#0000001#e0e0e08
> +0#0000000#ffffff0@74
|~+0#4040ff13&| @73
|═+0#e000002&@74
|l|a|t|e|r| |m|e|s@1|a|g|e| @61
|m|o|r|e| @70
|:+0#0000000&|e|c|h|o|w|i|n| |'|m|o|r|e|'| @59
@57|0|,|0|-|1| @8|A|l@1|
4 changes: 4 additions & 0 deletions src/testdir/test_messages.vim
Expand Up @@ -475,6 +475,10 @@ func Test_echowindow()
call term_sendkeys(buf, "\<CR>")
call VerifyScreenDump(buf, 'Test_echowindow_7', {})

call term_sendkeys(buf, ":tabnew\<CR>")
call term_sendkeys(buf, ":echowin 'more'\<CR>")
call VerifyScreenDump(buf, 'Test_echowindow_8', {})

" clean up
call StopVimInTerminal(buf)
call delete('XtestEchowindow')
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -699,6 +699,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
591,
/**/
590,
/**/
Expand Down

0 comments on commit 4569020

Please sign in to comment.