From 4569020538f76cab588f723bd7243e3896937568 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Mon, 26 Sep 2022 12:57:11 +0100 Subject: [PATCH] patch 9.0.0591: message window popup shows on only one tab page Problem: Message window popup shows on only one tab page. (Naruhiko Nishino) Solution: Show the message window popup on all tab pages. (closes #11231) --- src/popupwin.c | 2 ++ src/testdir/dumps/Test_echowindow_8.dump | 8 ++++++++ src/testdir/test_messages.vim | 4 ++++ src/version.c | 2 ++ 4 files changed, 16 insertions(+) create mode 100644 src/testdir/dumps/Test_echowindow_8.dump diff --git a/src/popupwin.c b/src/popupwin.c index 4cc7dec6fa53c..aae546566efc5 100644 --- a/src/popupwin.c +++ b/src/popupwin.c @@ -2053,6 +2053,8 @@ popup_create(typval_T *argvars, typval_T *rettv, create_type_T type) } } } + else if (popup_is_notification(type)) + tabnr = -1; // show on all tabs // Create the window and buffer. wp = win_alloc_popup_win(); diff --git a/src/testdir/dumps/Test_echowindow_8.dump b/src/testdir/dumps/Test_echowindow_8.dump new file mode 100644 index 0000000000000..d57d43787b086 --- /dev/null +++ b/src/testdir/dumps/Test_echowindow_8.dump @@ -0,0 +1,8 @@ +| +8#0000001#e0e0e08|+| |[|N|o| |N|a|m|e|]| | +2#0000000#ffffff0|[|N|o| |N|a|m|e|]| | +1&&@49|X+8#0000001#e0e0e08 +> +0#0000000#ffffff0@74 +|~+0#4040ff13&| @73 +|═+0#e000002&@74 +|l|a|t|e|r| |m|e|s@1|a|g|e| @61 +|m|o|r|e| @70 +|:+0#0000000&|e|c|h|o|w|i|n| |'|m|o|r|e|'| @59 +@57|0|,|0|-|1| @8|A|l@1| diff --git a/src/testdir/test_messages.vim b/src/testdir/test_messages.vim index 0100ba97ea6c2..a32ff512a4fab 100644 --- a/src/testdir/test_messages.vim +++ b/src/testdir/test_messages.vim @@ -475,6 +475,10 @@ func Test_echowindow() call term_sendkeys(buf, "\") call VerifyScreenDump(buf, 'Test_echowindow_7', {}) + call term_sendkeys(buf, ":tabnew\") + call term_sendkeys(buf, ":echowin 'more'\") + call VerifyScreenDump(buf, 'Test_echowindow_8', {}) + " clean up call StopVimInTerminal(buf) call delete('XtestEchowindow') diff --git a/src/version.c b/src/version.c index 0d7dadaf7de50..d17276bb9e942 100644 --- a/src/version.c +++ b/src/version.c @@ -699,6 +699,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 591, /**/ 590, /**/