Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
patch 8.1.0165: :clist output can be very long
Problem:    :clist output can be very long.
Solution:   Support filtering :clist entries. (Yegappan Lakshmanan)
  • Loading branch information
brammool committed Jul 8, 2018
1 parent fd35811 commit 4cde86c
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 1 deletion.
18 changes: 17 additions & 1 deletion src/quickfix.c
Expand Up @@ -3051,6 +3051,7 @@ qf_list(exarg_T *eap)
int qfFileAttr;
int qfSepAttr;
int qfLineAttr;
int filter_entry;
int all = eap->forceit; /* if not :cl!, only show
recognised errors */
qf_info_T *qi = &ql_info;
Expand Down Expand Up @@ -3120,7 +3121,6 @@ qf_list(exarg_T *eap)
{
if ((qfp->qf_valid || all) && idx1 <= i && i <= idx2)
{
msg_putchar('\n');
if (got_int)
break;

Expand All @@ -3141,6 +3141,20 @@ qf_list(exarg_T *eap)
vim_snprintf((char *)IObuff, IOSIZE, "%2d %s",
i, (char *)fname);
}

// Support for filtering entries using :filter /pat/ clist
filter_entry = 1;
if (qfp->qf_module != NULL && *qfp->qf_module != NUL)
filter_entry &= message_filtered(qfp->qf_module);
if (fname != NULL)
filter_entry &= message_filtered(fname);
if (qfp->qf_pattern != NULL)
filter_entry &= message_filtered(qfp->qf_pattern);
filter_entry &= message_filtered(qfp->qf_text);
if (filter_entry)
goto next_entry;

msg_putchar('\n');
msg_outtrans_attr(IObuff, i == qi->qf_lists[qi->qf_curlist].qf_index
? HL_ATTR(HLF_QFL) : qfFileAttr);

Expand Down Expand Up @@ -3175,6 +3189,7 @@ qf_list(exarg_T *eap)
out_flush(); /* show one line at a time */
}

next_entry:
qfp = qfp->qf_next;
if (qfp == NULL)
break;
Expand Down Expand Up @@ -4186,6 +4201,7 @@ ex_make(exarg_T *eap)
}
if (res >= 0)
qf_list_changed(qi, qi->qf_curlist);

// Remember the current quickfix list identifier, so that we can
// check for autocommands changing the current quickfix list.
save_qfid = qi->qf_lists[qi->qf_curlist].qf_id;
Expand Down
17 changes: 17 additions & 0 deletions src/testdir/test_quickfix.vim
Expand Up @@ -3487,3 +3487,20 @@ func Test_autocmd_changelist()
call Xautocmd_changelist('c')
call Xautocmd_changelist('l')
endfunc

" Tests for the ':filter /pat/ clist' command
func Test_filter_clist()
cexpr ['Xfile1:10:10:Line 10', 'Xfile2:15:15:Line 15']
call assert_equal([' 2 Xfile2:15 col 15: Line 15'],
\ split(execute('filter /Line 15/ clist'), "\n"))
call assert_equal([' 1 Xfile1:10 col 10: Line 10'],
\ split(execute('filter /Xfile1/ clist'), "\n"))
call assert_equal([], split(execute('filter /abc/ clist'), "\n"))

call setqflist([{'module' : 'abc', 'pattern' : 'pat1'},
\ {'module' : 'pqr', 'pattern' : 'pat2'}], ' ')
call assert_equal([' 2 pqr:pat2: '],
\ split(execute('filter /pqr/ clist'), "\n"))
call assert_equal([' 1 abc:pat1: '],
\ split(execute('filter /pat1/ clist'), "\n"))
endfunc
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -789,6 +789,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
165,
/**/
164,
/**/
Expand Down

0 comments on commit 4cde86c

Please sign in to comment.