Permalink
Browse files

patch 7.4.2145

Problem:    Win32: Using CreateThread/ExitThread is not safe.
Solution:   Use _beginthreadex and return from the thread. (Ken Takata)
  • Loading branch information...
1 parent 796aa9c commit 86f2cd5bc574c23fa276d7f57cd1300e24222913 @brammool brammool committed Aug 2, 2016
Showing with 5 additions and 3 deletions.
  1. +3 −3 src/os_win32.c
  2. +2 −0 src/version.c
View
@@ -4267,7 +4267,7 @@ sub_process_writer(LPVOID param)
/* finished all the lines, close pipe */
CloseHandle(g_hChildStd_IN_Wr);
- ExitThread(0);
+ return 0;
}
@@ -4491,8 +4491,8 @@ mch_system_piped(char *cmd, int options)
if (options & SHELL_WRITE)
{
- HANDLE thread =
- CreateThread(NULL, /* security attributes */
+ HANDLE thread = (HANDLE)
+ _beginthreadex(NULL, /* security attributes */
0, /* default stack size */
sub_process_writer, /* function to be executed */
g_hChildStd_IN_Wr, /* parameter */
View
@@ -764,6 +764,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 2145,
+/**/
2144,
/**/
2143,

0 comments on commit 86f2cd5

Please sign in to comment.