From 90fba5627b361dbc970b3afc2eebf7411c49a0cc Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Fri, 9 Jul 2021 19:17:55 +0200 Subject: [PATCH] patch 8.2.3133: Vim9: memory leak when add() fails Problem: Vim9: memory leak when add() fails. Solution: Allocate listitem_T after type check. --- src/list.c | 3 ++- src/version.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/list.c b/src/list.c index 9aec823eef2d3..d138d868cdad8 100644 --- a/src/list.c +++ b/src/list.c @@ -602,11 +602,12 @@ list_append(list_T *l, listitem_T *item) int list_append_tv(list_T *l, typval_T *tv) { - listitem_T *li = listitem_alloc(); + listitem_T *li; if (l->lv_type != NULL && l->lv_type->tt_member != NULL && check_typval_arg_type(l->lv_type->tt_member, tv, 0) == FAIL) return FAIL; + li = listitem_alloc(); if (li == NULL) return FAIL; copy_tv(tv, &li->li_tv); diff --git a/src/version.c b/src/version.c index e2108a025a9ac..39d8f1455c288 100644 --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 3133, /**/ 3132, /**/