Permalink
Browse files

patch 7.4.2212

Problem:    Mark " is not set when closing a window in another tab. (Guraga)
Solution:   Check all tabs for the window to be valid. (based on patch by
            Hirohito Higashi, closes #974)
  • Loading branch information...
1 parent e56132b commit e59215c7dcae17b03daf39517560cfaa03314f5a @brammool brammool committed Aug 14, 2016
Showing with 58 additions and 3 deletions.
  1. +2 −2 src/buffer.c
  2. +1 −0 src/proto/window.pro
  3. +30 −0 src/testdir/test_viminfo.vim
  4. +2 −0 src/version.c
  5. +23 −1 src/window.c
View
@@ -475,7 +475,7 @@ close_buffer(
if (win != NULL
#ifdef FEAT_WINDOWS
- && win_valid(win) /* in case autocommands closed the window */
+ && win_valid_any_tab(win) /* in case autocommands closed the window */
#endif
)
{
@@ -581,7 +581,7 @@ close_buffer(
if (
#ifdef FEAT_WINDOWS
- win_valid(win) &&
+ win_valid_any_tab(win) &&
#else
win != NULL &&
#endif
@@ -4,6 +4,7 @@ void get_wincmd_addr_type(char_u *arg, exarg_T *eap);
int win_split(int size, int flags);
int win_split_ins(int size, int flags, win_T *new_wp, int dir);
int win_valid(win_T *win);
+int win_valid_any_tab(win_T *win);
int win_count(void);
int make_windows(int count, int vertical);
void win_move_after(win_T *win1, win_T *win2);
@@ -425,3 +425,33 @@ func Test_viminfo_file_marks()
call delete('Xviminfo')
endfunc
+
+func Test_viminfo_file_mark_tabclose()
+ tabnew Xtestfileintab
+ call setline(1, ['a','b','c','d','e'])
+ 4
+ q!
+ wviminfo Xviminfo
+ sp Xviminfo
+ /^> .*Xtestfileintab
+ let lnum = line('.')
+ while 1
+ if lnum == line('$')
+ call assert_false(1, 'mark not found in Xtestfileintab')
+ break
+ endif
+ let lnum += 1
+ let line = getline(lnum)
+ if line == ''
+ call assert_false(1, 'mark not found in Xtestfileintab')
+ break
+ endif
+ if line =~ "^\t\""
+ call assert_equal('4', substitute(line, ".*\"\t\\(\\d\\).*", '\1', ''))
+ break
+ endif
+ endwhile
+
+ call delete('Xviminfo')
+ silent! bwipe Xtestfileintab
+endfunc
View
@@ -764,6 +764,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 2212,
+/**/
2211,
/**/
2210,
View
@@ -1358,7 +1358,7 @@ win_init_some(win_T *newp, win_T *oldp)
#if defined(FEAT_WINDOWS) || defined(PROTO)
/*
- * Check if "win" is a pointer to an existing window.
+ * Check if "win" is a pointer to an existing window in the current tab page.
*/
int
win_valid(win_T *win)
@@ -1374,6 +1374,28 @@ win_valid(win_T *win)
}
/*
+ * Check if "win" is a pointer to an existing window in any tab page.
+ */
+ int
+win_valid_any_tab(win_T *win)
+{
+ win_T *wp;
+ tabpage_T *tp;
+
+ if (win == NULL)
+ return FALSE;
+ FOR_ALL_TABPAGES(tp)
+ {
+ FOR_ALL_WINDOWS_IN_TAB(tp, wp)
+ {
+ if (wp == win)
+ return TRUE;
+ }
+ }
+ return FALSE;
+}
+
+/*
* Return the number of windows.
*/
int

0 comments on commit e59215c

Please sign in to comment.