Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build 8.0.1050 and later if system has libvterm installed #2080

Closed
cglogic opened this issue Sep 12, 2017 · 5 comments
Closed

Can't build 8.0.1050 and later if system has libvterm installed #2080

cglogic opened this issue Sep 12, 2017 · 5 comments

Comments

@cglogic
Copy link

cglogic commented Sep 12, 2017

After patch 8.0.1050 build fail with installed libvterm in system. Version 8.0.1049 builds fine.

libvterm/src/mouse.c:73:6: error: conflicting types for 'vterm_mouse_button'
void vterm_mouse_button(VTerm *vt, int button, int pressed, VTermModifier mod)
     ^
/usr/local/include/vterm.h:154:6: note: previous declaration is here
void vterm_mouse_button(VTerm *vt, int button, bool pressed, VTermModifier mod);
     ^
1 error generated.
*** Error code 1
@mattn
Copy link
Member

mattn commented Sep 12, 2017

It seems header path conflicting. You have /usr/local/include/vterm.h and -I/usr/local/include is prefered that -Ilibvterm/include. So configure should be fixed.

@cglogic
Copy link
Author

cglogic commented Sep 12, 2017

I just do the following:

git clone
./configure
make

And have this error. This issue with my environment or vim itself?

@k-takata
Copy link
Member

How about this patch?

--- a/src/Makefile
+++ b/src/Makefile
@@ -3299,7 +3299,7 @@ objects/channel.o: channel.c
 Makefile:
 	@echo The name of the makefile MUST be "Makefile" (with capital M)!!!!
 
-CCCTERM = $(CCC) -Ilibvterm/include -DINLINE="" \
+CCCTERM = $(CCC_NF) -Ilibvterm/include $(ALL_CFLAGS) -DINLINE="" \
 	  -DVSNPRINTF=vim_vsnprintf \
 	  -DIS_COMBINING_FUNCTION=utf_iscomposing_uint \
 	  -DWCWIDTH_FUNCTION=utf_uint2cells

@mattn
Copy link
Member

mattn commented Sep 12, 2017

This issue with my environment or vim itself?

No No. This is caused by configure script of vim.

@cglogic
Copy link
Author

cglogic commented Sep 12, 2017

Thanks @k-takata! Patch fixes this issue.

adizero pushed a commit to adizero/vim that referenced this issue May 19, 2018
Problem:    Build failure if libvterm installed on the system. (Oleh
            Hushchenkov)
Solution:   Change the CCCTERM argument order. (Ken Takata, closes vim#2080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants