New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible NPD error #3711
Comments
|
As this comes from libvterm, cc @leonerd |
|
The check for vterm_obtain_state() to return null is bogus, that function never returns null. |
|
Is it possible that when memory resource is limited then the return value is NULL? |
|
Is it possible that when memory resource is limited then the return value is NULL?
No, then it will crash. It could be useful to check for that and return
NULL then.
…--
hundred-and-one symptoms of being an internet addict:
39. You move into a new house and decide to Netscape before you landscape.
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
I suppose this is fixed by cd929f7? |
|
Yes, now vterm_obtain_state() can return NULL. |

Hi, recently I use fuzzing to check the vim and I find an NPD problem.




In src/libvterm/src/termscreen.c
This could return a null pointer for the caller function vterm_obtain_screen and store in the vt->screen.
This null screen is return to create_vterm function in src/terminal.c
then again in vterm_screen_set_callbacks function defined in src/libvterm/src/termscreen.c
The callback function is set to a null pointer screen.
The potential problem is that you can set a callback function to a predefined NULL memory address which might lead to more problem.
I wonder this is a true problem in vim or not, could you help to verify it?
I am looking forward to your reply!
The text was updated successfully, but these errors were encountered: