New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import rust files #1356
Import rust files #1356
Conversation
Oh, one thing I forgot:
I am on the Rust core team, and am one of the maintainers of |
If I am not mistaking, There are lots of examples of this convention, though e.g. |
this is for #1354 Also plugin/rust.vim only seems to be about syntastic, so we can probably skip that. syntax/rust.vim and indent/rust.vim look fine Also you might want to mention in those files, that they are maintained at https://github.com/rust-lang/rust.vim so that people having issues can direct them directly to the upstream repository. |
Steve Klabnik wrote:
Oh, one thing I forgot:
> When you do, please mention who you are, the license under which
> this is developed and that you give us allowance to distribute it
> with Vim.
I am on the Rust core team, and am one of the maintainers of
`rust.vim`. rust.vim is distributed under the terms of both the MIT
license and the Apache License (Version 2.0), at your option. As such,
you don't need me to allow it, but I allow it regardless „
Please update the headeer of each file to make clear where users should
send comments/patches.
Please add a remark about the license. I think that using MIT is fine
and does not conflict with how Vim is distributed.
A link to the github repository probably covers both. E.g.:
For bugs, patches and license go to https://github.com/rust-lang/rust.vim
…--
hundred-and-one symptoms of being an internet addict:
196. Your computer costs more than your car.
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Thanks @chrisbra and @brammool ! I've pushed a second commit; please let me know if you want me to squash them.
Ah yes, we probably have some extra stuff that's not needed. I can remove them. syntastic has been causing us headaches anyway... I'll push a commit with this.
I've pushed a second commit that added |
A few more remarks. Please remove loading the matchit plugin, that is a user preference unrelated to rust. Please use a tabstop of 8. And adjust the modeline for that. The header for runtime/ftplugin/rust.vim says it's a syntax file. As mentioned, please rename the doc file to ft_rust.vim The ftplugin file is missing the link to the github project. |
A quick update on this PR: the last few weeks have been very busy for me, but I intend to address @brammool 's comments no later than next week. Sorry about taking so long here! |
From rust-lang/rust.vim@732b5fc Some modifications as per vim#1356 that will be folded back upstream.
I believe I have now addressed all the review comments. Thanks again for your patience here. |
Any updates on this? I think this would be a great contribution. |
Looks like this Travis failure was spurious, so I didn't say anything. Happy to do whatever to get this merged. |
included as of 3c2881d |
Thank you so much! |
This is my first contribution to vim, so please bear with me as I learn the ropes.
This patch imports rust-lang/rust.vim@732b5fc into vim itself. I've built
vim
and confirmed that at least the syntax highlighting is working; frankly, I don't use many of its other features myself.I am not an expert on vim plugins; some of the files included in
rust.vim
don't have a directory here in vim itself, likeafter/syntax
. I am not sure if they're needed when not run as a plugin.Any and all feedback welcome; I'm happy to update with any requirements. Thanks!
Addresses #1354