Regression: Pack plugins are loaded twice (after 8.0.0612) #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A side effect of adding the pack dirs earlier to 'runtimepath' (by calling add_pack_start_dirs()) is that this call that was originally meant to only load the traditional plugins now also loads the pack plugins as well (fortunately, in the right order):
source_runtime((char_u *)"plugin/**/*.vim", DIP_ALL | DIP_NOAFTER)
The following invocation of load_start_packages() is superfluous and must be dropped to avoid duplicate loading of pack plugins. Instead, only set the did_source_packages flag (as would have done by the dropped call) to neutralize the effect of :packloadall.
The existing Test_after_comes_later() verifies the ordering of plugin loads, but because :scriptnames just records the _first_ load of a script, it cannot ensure that each plugin is loaded only once.
Record each plugin load in g:sequence, and assert ordering (again) and uniqueness (new) in a separate check.
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
+ Coverage 75.11% 75.12% +<.01%
==========================================
Files 76 76
Lines 125109 125108 -1
==========================================
+ Hits 93978 93983 +5
+ Misses 31131 31125 -6
Continue to review full report at Codecov.
|
dpelle
pushed a commit
to dpelle/vim
that referenced
this pull request
Jul 31, 2017
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim#1801)
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Aug 21, 2017
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim/vim#1801)
vim/vim@07ecfa6
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Aug 22, 2017
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim/vim#1801)
vim/vim@07ecfa6
nateozem
pushed a commit
to nateozem/neovim
that referenced
this pull request
Oct 5, 2017
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim/vim#1801)
vim/vim@07ecfa6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of adding the pack dirs earlier to
'runtimepath'(by callingadd_pack_start_dirs()) is that this call that was originally meant to only load the traditional plugins now also loads the pack plugins as well (fortunately, in the right order):The following invocation of
load_start_packages()is superfluous and must be dropped to avoid duplicate loading of pack plugins. Instead, only set thedid_source_packagesflag (as would have done by the dropped call) to neutralize the effect of:packloadall.The existing
Test_after_comes_later()verifies the ordering of plugin loads, but because :scriptnames just records the first load of a script, it cannot ensure that each plugin is loaded only once.Record each plugin load in
g:sequence, and assert ordering (again) and uniqueness (new) in a separate check.