Change operation may reset restart_edit #18585
Conversation
Problem: Change operation may reset restart_edit when coming from a
mapping (Pierre Ganty).
Solution: Only save and restore restart_edit when insertmode is set;
handle commands coming from mappings the same as when they
were actually typed.
fixes: vim#18567
Signed-off-by: Christian Brabandt <cb@256bit.org>
| call setline(1, ['one two three', 'four five six']) | ||
| onoremap <buffer> gb <cmd>normal! V<cr> | ||
| call cursor(1, 2) | ||
| " the first <ESC> should enter insert mode directly |
There was a problem hiding this comment.
| " the first <ESC> should enter insert mode directly | |
| " the first <ESC> should exit insert mode directly |
|
I'm not sure what the initial intention for this saving and restoring of nnoremap <F2> Vcabc<Esc>Before this PR, when typing It's difficult to make everything work as expected... |
correct, but it also means, there is an inconsistency between a command coming from a mapping and a command being interactively typed. If you type the right-hand side of the mapping interactively after |
|
As I said, it's hard to decide what behavior one expects. |
|
yeah, it's gonna be a backwards incompatible change. Let's not do it (at least now). |
2 participants
Problem: Change operation may reset restart_edit when coming from a
mapping (Pierre Ganty).
Solution: Only save and restore restart_edit when insertmode is set;
handle commands coming from mappings the same as when they
were actually typed.
fixes: #18567