-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UseBlacklist and UseBlocklist to runtime/syntax/sshdconfig.vim #3258
Conversation
Add UseBlacklist to the sshdconfigKeyword syntax group since support for blacklistd has been added to OpenSSH since FreeBSD 11.1 and NetBSD 7. https://www.freebsd.org/releases/11.1R/relnotes.html http://www.netbsd.org/releases/formal-7/NetBSD-7.0.html Problem: UseBlacklist is not highlighted when editing sshd_config. Solution: Add UseBlacklist to sshdconfig.vim. (Samy Mahmoudi)
|
Add UseBlacklist to the sshdconfigKeyword syntax
group since support for blacklistd has been added
to OpenSSH since FreeBSD 11.1 and NetBSD 7.
https://www.freebsd.org/releases/11.1R/relnotes.html
http://www.netbsd.org/releases/formal-7/NetBSD-7.0.html
Problem: UseBlacklist is not highlighted when editing sshd_config.
Solution: Add UseBlacklist to sshdconfig.vim. (Samy Mahmoudi)
It's up to the maintainer to handle this: Dominik Fischer.
…--
FATHER: Did you kill all those guards?
LAUNCELOT: Yes ... I'm very sorry ...
FATHER: They cost fifty pounds each!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
I have written to Dominik Fischer to ask for his help. Besides, following the first link leads to https://svnweb.freebsd.org/base?view=revision&revision=305476 which may quicken understanding: Added UseBlacklist option to sshd, which defaults to off. |
|
I am sorry that this went under my radar and will care for it shortly. Thanks @samy-mahmoudi for notifying me again. |
|
Nice to see you again Dominik! You are welcome. |
|
Related to #5753 |
Add UseBlocklist to the sshdconfigKeyword syntax group since blacklistd was renamed blocklistd upstream (NetBSD). These changes have not been imported into all the relevant operating systems (e.g. FreeBSD) yet, so maintain UseBlacklist in this syntax group until the transition is done. http://mail-index.netbsd.org/current-users/2020/06/15/msg038868.html https://reviews.freebsd.org/rS363657 Problem: UseBlocklist is not highlighted when editing sshd_config. Solution: Add UseBlocklist to sshdconfig.vim. (Samy Mahmoudi)
Codecov Report
@@ Coverage Diff @@
## master #3258 +/- ##
=========================================
Coverage ? 88.67%
=========================================
Files ? 148
Lines ? 161860
Branches ? 0
=========================================
Hits ? 143524
Misses ? 18336
Partials ? 0 Continue to review full report at Codecov.
|
|
@brammool looks like I am the new maintainer of sshd here and I got pinged by another user about this just yesterday so I just approved this. Is it enough for you to incorporate these changes or should I send the changes to you by some other means? Its not completely clear from https://github.com/vim/vim/blob/master/CONTRIBUTING.md#syntax-indent-and-other-runtime-files |
|
@brammool looks like I am the new maintainer of sshd here and I got
pinged by another user about this just yesterday so I just approved
this. Is it enough for you to incorporate these changes or should I
send the changes to you by some other means? Its not completely clear
from
https://github.com/vim/vim/blob/master/CONTRIBUTING.md#syntax-indent-and-other-runtime-files
I'll add the two new lines. The Last-Change date in the header will be
updated too then. If you would like to make more changes to the header
please send me a diff or the whole new file. For these runtime files a PR
isn't really needed since there are no tests being triggered.
…--
How To Keep A Healthy Level Of Insanity:
9. As often as possible, skip rather than walk.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
Thanks! |
Add UseBlacklist to the sshdconfigKeyword syntax
group since support for blacklistd has been added
to OpenSSH since FreeBSD 11.1 and NetBSD 7.
https://www.freebsd.org/releases/11.1R/relnotes.html
http://www.netbsd.org/releases/formal-7/NetBSD-7.0.html
Problem: UseBlacklist is not highlighted when editing sshd_config.
Solution: Add UseBlacklist to sshdconfig.vim. (Samy Mahmoudi)
Update (2020-10-07): add a second commit to this PR
Add UseBlocklist to the sshdconfigKeyword syntax group
since blacklistd was renamed blocklistd upstream (NetBSD).
These changes have not been imported into all the relevant
operating systems (e.g. FreeBSD) yet, so maintain UseBlacklist
in this syntax group until the transition is done.
http://mail-index.netbsd.org/current-users/2020/06/15/msg038868.html
https://reviews.freebsd.org/rS363657
Problem: UseBlocklist is not highlighted when editing sshd_config.
Solution: Add UseBlocklist to sshdconfig.vim. (Samy Mahmoudi)