Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseBlacklist and UseBlocklist to runtime/syntax/sshdconfig.vim #3258

Closed
wants to merge 2 commits into from

Conversation

samy-mahmoudi
Copy link

@samy-mahmoudi samy-mahmoudi commented Jul 28, 2018

Add UseBlacklist to the sshdconfigKeyword syntax
group since support for blacklistd has been added
to OpenSSH since FreeBSD 11.1 and NetBSD 7.

https://www.freebsd.org/releases/11.1R/relnotes.html
http://www.netbsd.org/releases/formal-7/NetBSD-7.0.html

Problem: UseBlacklist is not highlighted when editing sshd_config.
Solution: Add UseBlacklist to sshdconfig.vim. (Samy Mahmoudi)

Update (2020-10-07): add a second commit to this PR
Add UseBlocklist to the sshdconfigKeyword syntax group
since blacklistd was renamed blocklistd upstream (NetBSD).
These changes have not been imported into all the relevant
operating systems (e.g. FreeBSD) yet, so maintain UseBlacklist
in this syntax group until the transition is done.

http://mail-index.netbsd.org/current-users/2020/06/15/msg038868.html
https://reviews.freebsd.org/rS363657

Problem: UseBlocklist is not highlighted when editing sshd_config.
Solution: Add UseBlocklist to sshdconfig.vim. (Samy Mahmoudi)

Add UseBlacklist to the sshdconfigKeyword syntax
group since support for blacklistd has been added
to OpenSSH since FreeBSD 11.1 and NetBSD 7.

https://www.freebsd.org/releases/11.1R/relnotes.html
http://www.netbsd.org/releases/formal-7/NetBSD-7.0.html

Problem:    UseBlacklist is not highlighted when editing sshd_config.
Solution:   Add UseBlacklist to sshdconfig.vim. (Samy Mahmoudi)
@brammool
Copy link
Contributor

brammool commented Jul 28, 2018 via email

@samy-mahmoudi
Copy link
Author

samy-mahmoudi commented Jul 28, 2018

I have written to Dominik Fischer to ask for his help.

Besides, following the first link leads to https://svnweb.freebsd.org/base?view=revision&revision=305476 which may quicken understanding:

Added UseBlacklist option to sshd, which defaults to off.
To enable the functionality, use '-o UseBlacklist=yes' on
the command line, or uncomment in the sshd_config file.

@dffischer
Copy link

I am sorry that this went under my radar and will care for it shortly. Thanks @samy-mahmoudi for notifying me again.

@samy-mahmoudi
Copy link
Author

Nice to see you again Dominik! You are welcome.

@brammool
Copy link
Contributor

brammool commented Jun 8, 2020

Related to #5753

Add UseBlocklist to the sshdconfigKeyword syntax group
since blacklistd was renamed blocklistd upstream (NetBSD).
These changes have not been imported into all the relevant
operating systems (e.g. FreeBSD) yet, so maintain UseBlacklist
in this syntax group until the transition is done.

http://mail-index.netbsd.org/current-users/2020/06/15/msg038868.html
https://reviews.freebsd.org/rS363657

Problem:    UseBlocklist is not highlighted when editing sshd_config.
Solution:   Add UseBlocklist to sshdconfig.vim. (Samy Mahmoudi)
@samy-mahmoudi samy-mahmoudi changed the title Add UseBlacklist to runtime/syntax/sshdconfig.vim Add UseBlacklist and UseBlocklist to runtime/syntax/sshdconfig.vim Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8e85db0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3258   +/-   ##
=========================================
  Coverage          ?   88.67%           
=========================================
  Files             ?      148           
  Lines             ?   161860           
  Branches          ?        0           
=========================================
  Hits              ?   143524           
  Misses            ?    18336           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e85db0...c23cd6f. Read the comment docs.

@Jakuje
Copy link

Jakuje commented Oct 27, 2022

@brammool looks like I am the new maintainer of sshd here and I got pinged by another user about this just yesterday so I just approved this. Is it enough for you to incorporate these changes or should I send the changes to you by some other means? Its not completely clear from https://github.com/vim/vim/blob/master/CONTRIBUTING.md#syntax-indent-and-other-runtime-files

@brammool
Copy link
Contributor

brammool commented Nov 6, 2022 via email

@brammool brammool closed this Nov 6, 2022
@Jakuje
Copy link

Jakuje commented Nov 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants