New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse quote in command arguments in %!. #3523

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@mattn

mattn commented Oct 9, 2018

fixes #1743

Show outdated Hide outdated src/ex_cmds.c Outdated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 9, 2018

Codecov Report

Merging #3523 into master will decrease coverage by 74.67%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3523       +/-   ##
===========================================
- Coverage   77.21%    2.53%   -74.68%     
===========================================
  Files          99       91        -8     
  Lines      139018   128676    -10342     
===========================================
- Hits       107348     3268   -104080     
- Misses      31670   125408    +93738
Impacted Files Coverage Δ
src/ex_cmds.c 0% <0%> (-79.89%) ⬇️
src/libvterm/src/unicode.c 0% <0%> (-100%) ⬇️
src/crypt_zip.c 0% <0%> (-100%) ⬇️
src/sha256.c 0% <0%> (-97.96%) ⬇️
src/gui_gtk_f.c 0% <0%> (-97.88%) ⬇️
src/arabic.c 0% <0%> (-96.65%) ⬇️
src/quickfix.c 0% <0%> (-92.99%) ⬇️
src/digraph.c 0% <0%> (-92.8%) ⬇️
src/blowfish.c 0% <0%> (-89.84%) ⬇️
src/xdiff/xpatience.c 0% <0%> (-89.23%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3dbcf...4ee2a78. Read the comment docs.

codecov-io commented Oct 9, 2018

Codecov Report

Merging #3523 into master will decrease coverage by 74.67%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3523       +/-   ##
===========================================
- Coverage   77.21%    2.53%   -74.68%     
===========================================
  Files          99       91        -8     
  Lines      139018   128676    -10342     
===========================================
- Hits       107348     3268   -104080     
- Misses      31670   125408    +93738
Impacted Files Coverage Δ
src/ex_cmds.c 0% <0%> (-79.89%) ⬇️
src/libvterm/src/unicode.c 0% <0%> (-100%) ⬇️
src/crypt_zip.c 0% <0%> (-100%) ⬇️
src/sha256.c 0% <0%> (-97.96%) ⬇️
src/gui_gtk_f.c 0% <0%> (-97.88%) ⬇️
src/arabic.c 0% <0%> (-96.65%) ⬇️
src/quickfix.c 0% <0%> (-92.99%) ⬇️
src/digraph.c 0% <0%> (-92.8%) ⬇️
src/blowfish.c 0% <0%> (-89.84%) ⬇️
src/xdiff/xpatience.c 0% <0%> (-89.23%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3dbcf...4ee2a78. Read the comment docs.

@mattn

This comment has been minimized.

Show comment
Hide comment
@mattn

mattn Oct 9, 2018

@h-east thanks your review. but I removed the comment since I thought the comment is not required.

mattn commented Oct 9, 2018

@h-east thanks your review. but I removed the comment since I thought the comment is not required.

@brammool

This comment has been minimized.

Show comment
Hide comment
@brammool

brammool Oct 9, 2018

Contributor
Contributor

brammool commented Oct 9, 2018

@brammool brammool closed this in 0664089 Oct 9, 2018

janlazo added a commit to janlazo/neovim that referenced this pull request Oct 10, 2018

vim-patch:8.1.0468: MS-Windows: filter command with pipe character fails
Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim/vim#1743, closes vim/vim#3523)
vim/vim@0664089

janlazo added a commit to janlazo/neovim that referenced this pull request Oct 10, 2018

vim-patch:8.1.0468: MS-Windows: filter command with pipe character fails
Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim/vim#1743, closes vim/vim#3523)
vim/vim@0664089

@janlazo janlazo referenced this pull request Oct 10, 2018

Merged

vim-patch:8.1.0468 #9101

justinmk added a commit to neovim/neovim that referenced this pull request Oct 10, 2018

vim-patch:8.1.0468: MS-Windows: filter command with pipe character fa…
…ils (#9101)

Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim/vim#1743, closes vim/vim#3523)
vim/vim@0664089

HiPhish pushed a commit to HiPhish/neovim that referenced this pull request Oct 11, 2018

vim-patch:8.1.0468: MS-Windows: filter command with pipe character fa…
…ils (neovim#9101)

Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim/vim#1743, closes vim/vim#3523)
vim/vim@0664089

ntak added a commit to ntak/vim that referenced this pull request Oct 12, 2018

patch 8.1.0468: MS-Windows: filter command with pipe character fails
Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim#1743, closes vim#3523)

ntak added a commit to ntak/vim that referenced this pull request Oct 19, 2018

patch 8.1.0468: MS-Windows: filter command with pipe character fails
Problem:    MS-Windows: Filter command with pipe character fails. (Johannes
            Riecken)
Solution:   Find the pipe character outside of quotes. (Yasuhiro Matsumoto,
            closes vim#1743, closes vim#3523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment