New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: bracketed paste remaining set after vim exits #3579

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@scauligi

scauligi commented Oct 30, 2018

Fixes #1671 (closed with no fix) caused by 62cf09b.

Due to 62cf09b, bracketed paste was getting set before going into termcap mode.
The terminal emulator appears to save this setting, so when vim comes out of termcap,
the bracketed paste option is restored (even if vim unset bracketed paste while in termcap).

This change causes settmode() to only toggle bracketed paste when vim is already in termcap.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 30, 2018

Codecov Report

Merging #3579 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3579      +/-   ##
==========================================
+ Coverage   77.04%   77.32%   +0.28%     
==========================================
  Files          99       99              
  Lines      136614   139175    +2561     
==========================================
+ Hits       105248   107615    +2367     
- Misses      31366    31560     +194
Impacted Files Coverage Δ
src/term.c 60.55% <100%> (+0.14%) ⬆️
src/xdiff/xemit.c 67.1% <0%> (-1.39%) ⬇️
src/if_python3.c 74.8% <0%> (-1.38%) ⬇️
src/if_python.c 76.55% <0%> (-1.31%) ⬇️
src/spellfile.c 73.97% <0%> (-1.06%) ⬇️
src/xdiff/xpatience.c 89.22% <0%> (-0.59%) ⬇️
src/if_perl.xs 86.12% <0%> (-0.31%) ⬇️
src/netbeans.c 27.03% <0%> (-0.28%) ⬇️
src/libvterm/src/termscreen.c 58.97% <0%> (-0.25%) ⬇️
src/xdiff/xhistogram.c 83.62% <0%> (-0.21%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833e5da...15ee304. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment