New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "set diffopt=algorithm:" would not occur an error. #3598

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@h-east

h-east commented Nov 5, 2018

Hi Bram and list,

It is as written in the subject.
Please include this.

--

Best regards,
Hirohito Higashi (h_east)

@codecov-io

This comment has been minimized.

codecov-io commented Nov 5, 2018

Codecov Report

Merging #3598 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
+ Coverage   77.31%   77.32%   +<.01%     
==========================================
  Files          99       99              
  Lines      139182   139183       +1     
==========================================
+ Hits       107610   107622      +12     
+ Misses      31572    31561      -11
Impacted Files Coverage Δ
src/diff.c 84.35% <100%> (+0.15%) ⬆️
src/channel.c 83.14% <0%> (-0.08%) ⬇️
src/gui_gtk_x11.c 48.06% <0%> (-0.05%) ⬇️
src/ex_docmd.c 79.24% <0%> (+0.01%) ⬆️
src/os_unix.c 57.34% <0%> (+0.04%) ⬆️
src/gui.c 57.08% <0%> (+0.1%) ⬆️
src/message.c 75.52% <0%> (+0.19%) ⬆️
src/term.c 60.57% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e353b5...f4aa80a. Read the comment docs.

@tonymec

This comment has been minimized.

tonymec commented Nov 5, 2018

Shouldn't one specify which algorithm, i.e., one of algorithm:myers, algorithm:minimal, algorithm:patience or algorithm:histogram but not just algorithm: followed by nothing?

Best regards,
Tony.

@chrisbra

This comment has been minimized.

Member

chrisbra commented Nov 5, 2018

Shouldn't one specify which algorithm

Yes, that's why an error message is suggested, if no algorithm is given.

@brammool brammool closed this in d072105 Nov 5, 2018

@h-east h-east deleted the h-east:check_diffopt_error branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment