New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle the location list window closure when it is still in use #3928

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@yegappan
Copy link

yegappan commented Feb 10, 2019

Vim crashes when the location list window is closed using an autocmd while
it is still in use. Properly handle this scenario.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #3928 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
+ Coverage   78.84%   78.85%   +<.01%     
==========================================
  Files         105      105              
  Lines      142076   142080       +4     
==========================================
+ Hits       112024   112036      +12     
+ Misses      30052    30044       -8
Impacted Files Coverage Δ
src/quickfix.c 93.44% <100%> (+0.01%) ⬆️
src/window.c 83.46% <100%> (+0.12%) ⬆️
src/evalfunc.c 88.44% <100%> (ø) ⬆️
src/eval.c 85.13% <100%> (ø) ⬆️
src/ui.c 49.92% <0%> (-0.08%) ⬇️
src/gui.c 58% <0%> (-0.06%) ⬇️
src/message.c 76.45% <0%> (-0.05%) ⬇️
src/terminal.c 75.12% <0%> (-0.05%) ⬇️
src/gui_gtk_x11.c 48.42% <0%> (+0.04%) ⬆️
src/channel.c 83.16% <0%> (+0.07%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c5632...afc6a35. Read the comment docs.

yegappan added some commits Feb 6, 2019

Memory allocated for 'switchbuf' option is not freed under some condi…
…tions. Not able to jump to a line in the location list when using an autocmd to close all the other windows
Opening a file from the location list window doesn't position the cur…
…sor correctly with an autocmd to close windows.

@yegappan yegappan force-pushed the yegappan:qfsetidx branch from a21139b to 517953c Feb 10, 2019

@dpelle

This comment has been minimized.

Copy link

dpelle commented Feb 10, 2019

Just to confirm that after applying the change, valgrind no longer gives errors when running:

$ valgrind vim --clean -S location-list-segv.vim 2> vg.log

@brammool brammool closed this in eeb1b9c Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment