Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test terminal cursor properties (visible, shape, color) #4256

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@dpelle
Copy link

commented Apr 14, 2019

This PR tests terminal cursor properties (visible, shape color).
Function term_getcursor() was already covered, but the returned
properties where not tested.

I also see that :help term_getcursor() does not document the
"color" property. It currently says:

                "dict" can have these members:
                   "visible"    one when the cursor is visible, zero when it
                                is hidden.
                   "blink"      one when the cursor is blinking, zero when it
                                is not blinking.
                   "shape"      1 for a block cursor, 2 for underline and 3
                                for a vertical bar.
@codecov-io

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #4256 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4256      +/-   ##
==========================================
+ Coverage   79.71%   79.72%   +0.01%     
==========================================
  Files         106      106              
  Lines      141579   141579              
==========================================
+ Hits       112858   112877      +19     
+ Misses      28721    28702      -19
Impacted Files Coverage Δ
src/channel.c 83.47% <0%> (-0.08%) ⬇️
src/message.c 76.58% <0%> (-0.05%) ⬇️
src/gui_gtk_x11.c 48.91% <0%> (ø) ⬆️
src/if_xcmdsrv.c 84.02% <0%> (+0.17%) ⬆️
src/gui.c 58.04% <0%> (+0.62%) ⬆️
src/libvterm/src/state.c 91.4% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0aaf3c...f20a723. Read the comment docs.

@brammool brammool closed this in 74e3d4e Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.