Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't scroll with border. #4650

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@rbtnn
Copy link

commented Jul 11, 2019

Can't scroll with border such as following case:

call popup_menu(repeat(['123456789'], 10), {
            \ 'maxheight' : 5,
            \ 'close' : 'button',
            \ })

popup

@codecov-io

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #4650 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
+ Coverage   81.34%   81.34%   +<.01%     
==========================================
  Files         111      111              
  Lines      144978   144978              
==========================================
+ Hits       117928   117936       +8     
+ Misses      27050    27042       -8
Impacted Files Coverage Δ
src/popupwin.c 94.55% <100%> (ø) ⬆️
src/gui_beval.c 62.5% <0%> (-0.87%) ⬇️
src/if_xcmdsrv.c 85.63% <0%> (-0.54%) ⬇️
src/terminal.c 81.21% <0%> (-0.04%) ⬇️
src/channel.c 83.98% <0%> (-0.04%) ⬇️
src/window.c 87.3% <0%> (-0.04%) ⬇️
src/os_unix.c 63.35% <0%> (+0.04%) ⬆️
src/gui.c 63.68% <0%> (+0.05%) ⬆️
src/ui.c 69.66% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247bf0d...cb04b8f. Read the comment docs.

@brammool brammool closed this in bd42b31 Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.