Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS-Windows: Fix tests related cmd.exe #4928

Closed
wants to merge 4 commits into from
Closed

MS-Windows: Fix tests related cmd.exe #4928

wants to merge 4 commits into from

Conversation

Milly
Copy link
Contributor

@Milly Milly commented Sep 13, 2019 •
edited

Improved test coverage on Windows.

  • Change external commands on Windows.
  • Fixed: If exists C:\tmp, isdirectory('/tmp') returns 1 and get error.
  • Remove duplicate tests (that added at 1a61339).

@Milly
Copy link
Contributor Author

Milly commented Sep 13, 2019

appveyor Messages

Build execution time has reached the maximum allowed time for your plan (60 minutes).

What causes... 😭

@Milly Milly mentioned this pull request Sep 13, 2019
Closed
@codecov-io
Copy link

codecov-io commented Oct 14, 2019 •
edited

Codecov Report

Merging #4928 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   81.59%   81.94%   +0.35%     
==========================================
  Files         134      134              
  Lines      146688   146925     +237     
==========================================
+ Hits       119685   120399     +714     
+ Misses      27003    26526     -477
Impacted Files Coverage Δ
src/libvterm/src/mouse.c 0% <0%> (-96.43%) ⬇️
src/libvterm/src/screen.c 56.96% <0%> (-31.56%) ⬇️
src/message.c 79.48% <0%> (-0.13%) ⬇️
src/netbeans.c 27.46% <0%> (-0.08%) ⬇️
src/version.c 92.1% <0%> (ø) ⬆️
src/channel.c 84.25% <0%> (+0.03%) ⬆️
src/drawscreen.c 83.5% <0%> (+0.07%) ⬆️
src/getchar.c 83% <0%> (+0.07%) ⬆️
src/normal.c 82.99% <0%> (+0.09%) ⬆️
src/ex_getln.c 71.31% <0%> (+0.1%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa7523...b98cd5a. Read the comment docs.

@Milly
Copy link
Contributor Author

Milly commented Oct 15, 2019

Remove duplicate tests (that added at 1a61339).

@brammool brammool closed this in 077ff43 Oct 27, 2019
@Milly Milly deleted the fix-wintest branch November 7, 2019 01:13
manuelschiller pushed a commit to manuelschiller/vim that referenced this pull request Nov 10, 2019
@brammool @manuelschiller
patch 8.1.2230: MS-Windows: testing external commands can be improved
af7a835 
Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim#4928)
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
2869553 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
ff77286 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
51e4827 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
9c9216b 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
59f3ba7 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
b1e2dd0 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
54febf4 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 10, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
d32f252 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
27e05ce 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
e242032 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
64ca09f 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
4a079cd 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
4825aad 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
63dcba4 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
4d3af53 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
524a9b0 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
a321ec2 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jul 11, 2022
@zeertzjq
vim-patch:8.1.2230: MS-Windows: testing external commands can be impr…
00e8db6 
…oved

Problem:    MS-Windows: testing external commands can be improved.
Solution:   Adjust tests, remove duplicate test. (closes vim/vim#4928)
vim/vim@077ff43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Milly @codecov-io @k-takata