Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip (portions of) tests that do not work as root #5020

Closed
wants to merge 2 commits into from

Conversation

@jamessan
Copy link

commented Oct 6, 2019

Added IsRoot() function to check for root, so that portions of a test can be skipped, and :CheckNotRoot to entirely skip a test.

jamessan added 2 commits Oct 6, 2019
@jamessan jamessan force-pushed the jamessan:failing-tests-under-root branch from 8dc100a to fc6de9b Oct 6, 2019
@brammool

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@jamessan

This comment has been minimized.

Copy link
Author

commented Oct 8, 2019

Would it be OK to bail out of tests completely? Why are tests being run as root?

This is happening in a throw away container. I could go through the extra steps of setting up a non-root user, making the data accessible to that user, running the tests from there, but that's just unnecessary scaffolding.

@brammool brammool closed this in 07282f0 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.