Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.vim from OS-specific setup script #5177

Closed
wants to merge 1 commit into from

Conversation

@178inaba
Copy link

178inaba commented Nov 5, 2019

When make test is executed, src/testdir/XfakeHOME/.viminfo remains.
This is a file created by setup.vim called by unix.vim when summarize.vim is executed.
In the first place, I think XfakeHOME does not have to be created when summarize.vim is executed.
Moreover, setup.vim is also called in runtest.vim, so it doesn't have to be called in the setup for each OS.
So I deleted the part that calls setup.vim from the setup script of each OS.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #5177 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5177      +/-   ##
==========================================
- Coverage      82%   81.99%   -0.02%     
==========================================
  Files         134      130       -4     
  Lines      147194   146930     -264     
==========================================
- Hits       120707   120471     -236     
+ Misses      26487    26459      -28
Impacted Files Coverage Δ
src/gui.c 63.84% <0%> (-0.62%) ⬇️
src/netbeans.c 27.23% <0%> (-0.3%) ⬇️
src/sign.c 94.41% <0%> (-0.28%) ⬇️
src/memfile.c 78.03% <0%> (-0.21%) ⬇️
src/mbyte.c 66.21% <0%> (-0.2%) ⬇️
src/window.c 88.27% <0%> (-0.04%) ⬇️
src/json_test.c
src/memfile_test.c
src/kword_test.c
src/message_test.c
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a3272...d240bd9. Read the comment docs.

@brammool

This comment has been minimized.

Copy link
Contributor

brammool commented Nov 5, 2019

This isn't right, sourcing setup.vim is required for the old style tests.
It can be omitted for summarize.vim, that should not be run like a test.

@brammool brammool closed this in 7d23204 Nov 5, 2019
@178inaba 178inaba deleted the 178inaba:remove_setup branch Nov 6, 2019
manuelschiller added a commit to manuelschiller/vim that referenced this pull request Nov 10, 2019
Problem:    Running tests may leave XfakeHOME behind.
Solution:   Source summarize.vim without using setup.vim. (closes vim#5177)
            Also fix that on MS-Windows the test log isn't echoed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.