Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTP for wildmenu #5303

Closed
wants to merge 1 commit into from

Conversation

@ntak
Copy link

ntak commented Dec 2, 2019

VTP breaks the BOLD + INVERSE combination. Fixed.

Reproduction:
$ vim --clean -u NONE
:set nocp
:set wildmenu
:set tgc
:set (Tab key repeatedly...)

Before the patch, it cannot be displayed well.
After patching, it can be displayed.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #5303 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5303      +/-   ##
==========================================
- Coverage   82.23%   82.23%   -0.01%     
==========================================
  Files         134      134              
  Lines      147605   147605              
==========================================
- Hits       121387   121386       -1     
- Misses      26218    26219       +1
Impacted Files Coverage Δ
src/screen.c 84.73% <ø> (ø) ⬆️
src/if_xcmdsrv.c 85.99% <0%> (-0.18%) ⬇️
src/drawline.c 85.3% <0%> (-0.14%) ⬇️
src/gui.c 63.68% <0%> (-0.11%) ⬇️
src/term.c 81.06% <0%> (-0.06%) ⬇️
src/terminal.c 81.81% <0%> (+0.03%) ⬆️
src/gui_gtk_x11.c 58.16% <0%> (+0.04%) ⬆️
src/channel.c 84.25% <0%> (+0.07%) ⬆️
src/ui.c 71.97% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3061390...d213573. Read the comment docs.

@ntak

This comment has been minimized.

Copy link
Author

ntak commented Dec 2, 2019

This may be a misunderstanding.
When I changed colorscheme in .vimrc, the intro display was broken. (such as desert)
I will reply, so please wait.
We apologize for the trouble.

@ntak

This comment has been minimized.

Copy link
Author

ntak commented Dec 2, 2019

It was before this patch that the intro display was broken.
I want to solve this problem with another patch.
This patch will be submitted as is.

@brammool brammool closed this in a050b94 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.