Adding COUNT and COUNT(DISTINCT) aggregation support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements comprehensive COUNT operations for ScalaSQL addressing issue com-lihaoyi#95: Core Implementation: - Add AggAnyOps.scala with count/countDistinct methods for Expr[T] - Add countBy/countDistinctBy methods to AggOps for grouped queries - Add implicit conversion in Dialect for AggAnyOps integration API Features: - count/countDistinct: COUNT(expr) and COUNT(DISTINCT expr) - countBy/countDistinctBy: COUNT(column) and COUNT(DISTINCT column) - Full cross-dialect support (PostgreSQL, MySQL, SQLite, H2, MS SQL) - Proper NULL handling (COUNT ignores NULL values) - Window function support with OVER clauses - Integration with existing aggregation patterns Test Coverage: - Basic COUNT operations and edge cases - Option type handling with NULL database values - Complex type support (UUID, BigDecimal, DateTime, Boolean) - GROUP BY with COUNT aggregations - Window functions, filters, joins, and complex expressions - Cross-platform compatibility testing Documentation: - Updated tutorial.md with COUNT examples and patterns - Added comprehensive reference.md API documentation - Updated cheatsheet.md with COUNT operations - Added window function documentation for COUNT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
COUNTandCOUNT(DISTINCT)aggregations? com-lihaoyi/scalasql#95Changes Made
Core Implementation
.countand.countDistinctmethods forExpr[T].countBy()and.countDistinctBy()methods for grouped queriesAggAnyOpsintegrationAPI Features
Purchase.select.map(_.productId).count→COUNT(product_id)Purchase.select.map(_.productId).countDistinct→COUNT(DISTINCT product_id)Purchase.select.countBy(_.productId)→COUNT(product_id)Purchase.select.countDistinctBy(_.productId)→COUNT(DISTINCT product_id).countBy(_.col).over.partitionBy(...)Test Coverage
Documentation
.sizedocumentationTest Plan