Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2184 - update documentation #116

Merged
merged 5 commits into from Sep 19, 2018
Merged

I2184 - update documentation #116

merged 5 commits into from Sep 19, 2018

Conversation

hillalex
Copy link
Collaborator

@hillalex hillalex commented Sep 18, 2018

Updated to reflect current state of backups, and to add Prometheus

Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete the second copy of the arch .png that is present here? There was an awkward case difference that we've finally stopped following :)

@hillalex
Copy link
Collaborator Author

👍

Copy link
Contributor

@MartinEden MartinEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. One suggested change, if it's not too painful: It would be nice to have a box around the docker-compose network for Prometheus, so we can show that internally AWS metrics is using port 5000, but that only the ports for the other two containers make it to the machine level.

@hillalex
Copy link
Collaborator Author

How's this?

@hillalex hillalex merged commit 69781c3 into master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants