Fix #1996 - detect unused variable in static property name

vimeo · Aug 9, 2019 · 5254b75 · 5254b75
1 parent 85c9b6b
commit 5254b75
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/PropertyAssignmentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/PropertyAssignmentAnalyzer.php
@@ -992,6 +992,10 @@ public static function analyzeStatic(
         $prop_name = $stmt->name;
 
         if (!$prop_name instanceof PhpParser\Node\Identifier) {
+            if (ExpressionAnalyzer::analyze($statements_analyzer, $prop_name, $context) === false) {
+                return false;
+            }
+
             if ($fq_class_name && !$context->ignore_variable_property) {
                 $codebase->analyzer->addMixedMemberName(
                     strtolower($fq_class_name) . '::$',

diff --git a/tests/UnusedVariableTest.php b/tests/UnusedVariableTest.php
@@ -1020,6 +1020,20 @@ function foo() : void {
                         A::$method();
                     }',
             ],
+            'usedAsStaticPropertyName' => [
+                '<?php
+                    class A {
+                        private static bool $something = false;
+
+                        public function foo() : void {
+                            $var = "something";
+
+                            if (true) {
+                                static::${$var} = true;
+                            }
+                        }
+                    }'
+            ],
         ];
     }