Fix setting of current_dir with 'root' command parameter #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'm quite new to psalm and I am currently trying to introduce it to Shopware. Works good so far, but I had an issue, when I was using psalm for our pre-commit hook. Due to our development setup it is necessary to set the
--rootcommand parameter, but psalm fails to load the autoloader files.After some researching I found out, that the
$current_dirvariable was not set to the given root directory, before searching for the composer files. This issue was introduce with #1904This PR fixes the issue and works nice in my environment.