Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorized file name and line in console output #4160

Merged
merged 2 commits into from Nov 27, 2021
Merged

Conversation

Rarst
Copy link
Contributor

@Rarst Rarst commented Sep 8, 2020

A quick take to back up screenshot in the issue, feel free to iterate on. :)

Fixes #4129

@orklah
Copy link
Collaborator

orklah commented Sep 26, 2021

Could you rebase and solve conflicts to see if the CI is still failing?

@Rarst
Copy link
Contributor Author

Rarst commented Sep 27, 2021

Rebased, there are some fails in ReportOutputTest that look to be directly because of output change.

From quick look test file is rather large with support for multiple output types, so not sure about adjusting it (and if this is agreed upon as desired output, been a while).

@orklah orklah marked this pull request as draft Nov 24, 2021
src/Psalm/Report/ConsoleReport.php Outdated Show resolved Hide resolved
@weirdan weirdan added the release:feature label Nov 27, 2021
@weirdan weirdan marked this pull request as ready for review Nov 27, 2021
@weirdan weirdan merged commit 66eb665 into vimeo:master Nov 27, 2021
16 of 17 checks passed
@weirdan
Copy link
Collaborator

weirdan commented Nov 27, 2021

Thanks!

@Rarst Rarst deleted the patch-2 branch Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants