Mark finfo_open and finfo_file as impure #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind adhering to the < 120 characters-per-line rule? |
sorry, wasn't aware the codebase has such a rule. the failed circle CI build does not show me a error message (can only see that it failed). |
You have to click through – I believe the error message is public Anyway, thanks! |
|
I need to create a circle ci account by a login via github button. Seems the logs are not public accessible without a login :-( |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* Mark finfo_open and finfo_file as impure * fix CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://psalm.dev/r/651cd68b91