Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null propagation in return #6952

Merged
merged 1 commit into from Nov 21, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Nov 21, 2021

this will fix #6931

I didn't add test because I don't know how to reproduce on this scale. I'd need multiple threads and somehow order them. However, it should be a simple change, I just excluded object types from the change I made in #6187 that prevented null propagation from signature to docblock when the two didn't match

@orklah orklah added the release:fix label Nov 21, 2021
@orklah orklah merged commit 4613927 into vimeo:master Nov 21, 2021
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant