Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent Psalm from considering throwing methods as unused just because they're immutable #6972

Merged
merged 2 commits into from Nov 22, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Nov 22, 2021

This will fix #6967

As discussed there, in the long term, we might want to reconsider the assumption that void and immutable methods are unused, given the current definition of immutability does not exclude at least some external side effects(like throwing an exception)

@orklah orklah added the release:fix label Nov 22, 2021
@orklah orklah merged commit eca56c0 into vimeo:master Nov 22, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant