Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include enum cases in const wildcards #7010

Merged
merged 1 commit into from Nov 28, 2021

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 28, 2021

Refs #6471

@weirdan weirdan added this to the PHP 8.1 milestone Nov 28, 2021
@weirdan weirdan requested a review from orklah Nov 28, 2021
@weirdan weirdan added the release:fix label Nov 28, 2021
if ($class_storage->is_enum) {
return new Type\Atomic\TEnumCase($return_type->fq_classlike_name, $return_type->const_name);
}
Copy link
Collaborator Author

@weirdan weirdan Nov 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the more special handling for enums I drop the better it works 😄

@weirdan weirdan merged commit 2df5f22 into vimeo:master Nov 28, 2021
16 of 17 checks passed
@weirdan weirdan deleted the cases-in-wildcards branch Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant