Defer cache directory creation until it's needed #8789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly, this is a bit of a hack, as we let `Config` to generate the cache directory name and then reset it to null from the cli entrypoint. Yet it's easier than passing a no-cache flag through so many layers of static calls. `$this->cache_directory_initialized` flag is used to make sure we attempt to create the directory only once. Fixes vimeo#4267
weirdan
added
the
release:fix
weirdan
added
the
release:deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, this is a bit of a hack, as we let
Configto generate thecache directory name and then reset it to null from the cli entrypoint.
Yet it's easier than passing a no-cache flag through so many layers of
static calls.
$this->cache_directory_initializedflag is used to make sure weattempt to create the directory only once.
Fixes #4267