Add validation for Class::Method names in CallMap#8826
Conversation
| 'Fiber::getReturn' => ['mixed'], | ||
| 'Fiber::getCurrent' => ['?self'], | ||
| 'Fiber::suspend' => ['mixed', 'value='=>'null|mixed'], | ||
| 'FiberError::__construct' => ['void'], |
There was a problem hiding this comment.
Moved to match alphabetical order.
| 'normalizer::isnormalized', | ||
| 'normalizer::normalize', | ||
| 'normalizer_get_raw_decomposition', | ||
| 'oauth_get_sbs', |
There was a problem hiding this comment.
These should be re-added. I will work on an updated list.
There was a problem hiding this comment.
do you want to do that now or in a next PR?
There was a problem hiding this comment.
Let me check this list before merging.
There was a problem hiding this comment.
The arrays should show only additions now.
We have problems where certain functions aren't ignored for specific PHP versions. If you run the test with PHP 8.1 it will tell you to remove some functions from the ignore list even though they will fail with PHP 8.0. This can be addressed separately.
There was a problem hiding this comment.
Yeah, that's an issue, CI is failing because of that. Maybe we should build the list with the version psalm uses for tests now and enforce that version in tests? The day where we want to change it, we'll have to update the list with the correct version?
There was a problem hiding this comment.
Yea, I'll look into it some more.
I'm pretty sure this tells us what functions/methods changed in 8.1 though :).
There was a problem hiding this comment.
@orklah Updated the ignore arrays to support php versions like the original $ignoredFunctions does. This should work for php 8.0 - 8.2, but there are probably a couple missing from php 8.2.
Looks like your github actions config doesn't enable most of the extensions anymore, but I generated the lists with as as many extensions as I could load.
There was a problem hiding this comment.
Most of the methods not ignored for PHP 8.0 are missing reflection information. It doesn't exactly mean that CallMap is right or wrong.
|
Seems great! A few errors to solve in CI and it can be merged! |
othercorey
force-pushed
the
callmap-methods
branch
from
1151baf to
cf91c5d
Compare
othercorey
changed the title
othercorey
force-pushed
the
callmap-methods
branch
2 times, most recently
from
0bd11b1 to
7461ebe
Compare
othercorey
force-pushed
the
callmap-methods
branch
from
7461ebe to
45e2992
Compare
othercorey
force-pushed
the
callmap-methods
branch
from
45e2992 to
e57079f
Compare
orklah
added
the
release:internal
|
Thanks! |
2 participants
We only validate classes that exist as the original provider only validate functions that exist.
Unreflectable methods are handled and validated. Sometimes these are methods that were removed in PHP and should be removed from the CallMap, but there are some like '__invoke' that are unreflectable.
Some of the methods in CallMap are missing return types, but this just ignores them for now.