-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot map <space> #10
Comments
Space (and a few other keys like Enter) unfortunately has some places where On Sun, Jul 20, 2014 at 6:52 PM, pevu notifications@github.com wrote:
|
This has been frustrating me in Muttator as well; I use Space in Vim to toggle folds, and I'd expect Enter to open the currently-selected email; however, with the following key mappings, neither key has any effect: nnoremap <Space> za
nnoremap <CR> M |
I've been trying out vimperator and this issue isn't letting me pass space through to videos, is there a way that we can make space pass through to the webpage (but not remapping it, as per this issue), so that we can play/pause videos and other things? Firefox handles scrolling too in this case. |
Is there a good way for me to find all the places where Space is hard coded? I would like a make a fork where space can be mapped. I use space for leader in vim and I would really love the same in vimperator. |
I modified one line in my local zipped copy of vimperator and I seem to have the functionality I want. https://github.com/vimperator/vimperator-labs/blob/master/vimperator/content/config.js#L305
To
And now I can map leader to Space. If anyone else wants to do this just navigate to your firefox profile/extensions (i.e. Then modify What problems may I have by doing this? If I do run into any, I will post them here. |
@adamryman no repro here. Perhaps one of us is missing something necessary? I made the change you described to content/config.js, updated my |
That is interesting, those do not work for me either. I realize now that I use leaders in a very nonstandard way. In vim, I leave I did the same in vimperator without realizing it. But it does work if you want this functionality. So follow my instructions and to use space as a leader key do the following
Then try pressing Let me know if this is functionality you wanted. It works for everything I wanted it to. |
@adamryman Brilliant! That does it. It's a complete hack, but it does the job for now. The mental switching of |
See vimperator/vimperator-labs#10 for the feature request and a hack-around by @adamryman.
@jwhitley Glad it worked for you! As far as the mental switch between Very happy that my little hack helped someone else out. If anyone wants to know how I did this, I just searched the codebase for " @jwhitley if you come across any weird issues that are related to this, please post them here. Also I will be studying your |
I'm used to map my Key to / for searching. Using the tip from @adamryman worked like a charm. |
@adamryman 's hack is really helpful. If somebody doesn't want to modify your local vimperator, add the following code hook in .vimperatorrc file.
|
Brilliant work: @adamryman @fx-kirin . @fx-kirin I'm using your patch in my .vimperatorrc at it works a treat. Thank you. |
This doesn't work:
This does:
They both show up as mapped keys, meaning I can :unmap afterwards, but the issue remains.
Space is a very conveniently placed key for just about everything, would be a shame to give it up to scrolling. And the default F is not in a convenient location for me (using Dvorak).
(Firefox 30, Windows 8.1 x64)
The text was updated successfully, but these errors were encountered: