Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'restart' command does not work in Firefox 45 #460

Closed
geotrader opened this issue Mar 12, 2016 · 7 comments
Closed

'restart' command does not work in Firefox 45 #460

geotrader opened this issue Mar 12, 2016 · 7 comments
Labels
bug

Comments

@geotrader
Copy link

@geotrader geotrader commented Mar 12, 2016

i using
・firefox 45 with chocolatey
・win10 64bit pro

I send "restart" command after firefox closed.
after it's not run, i waiting long time.

@timss timss changed the title command "restart" not worked 'restart' command does not work in Firefox 45 Mar 19, 2016
@timss timss added bug and removed compatibility labels Apr 29, 2016
@timss
Copy link
Member

@timss timss commented Apr 29, 2016

According to #496, the same can be seen with the newest release 3.13.0 with Firefox 46.

@kmorihiro
Copy link
Contributor

@kmorihiro kmorihiro commented May 19, 2016

How about commenting L988 out temporarily until Firefox fixes this problem?

https://github.com/vimperator/vimperator-labs/blob/master/common/content/liberator.js#L988

services.get("obs").notifyObservers(null, "quit-application-granted", null);
@timss
Copy link
Member

@timss timss commented May 22, 2016

Sorry about the delay. I may be in over my head, and I haven't been able to set aside the necessary time for following up on this issue. Looking to do so before or during next weekend.

In the mean time, yes, there are things about this function that could be deleted to make the restart function work again, such as L988 or possibly L995.

@timss
Copy link
Member

@timss timss commented Jul 24, 2016

https://bugzilla.mozilla.org/show_bug.cgi?id=1269859#c4

Removing quit-application-granted entirely more so now seems like a possible solution, but I'd like to hear what the Mozilla maintainer has to say first.

@timss
Copy link
Member

@timss timss commented Jul 27, 2016

The underlying issue has finally been tracked down, and was indeed introduced in version 45. A fix has been released in 48.0b9 and later.

For more information, please see the updates in the previous bug report as well as this one:

https://bugzilla.mozilla.org/show_bug.cgi?id=1284687

Until then, please restart your browser by starting it after closing using :xall, :restart etc., as you normally would if you're using a version affected.

@matreex
Copy link

@matreex matreex commented Aug 4, 2016

@gkatsev ,the problem had been miraculously working on firefox v48.0. 💯 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.